Implement full OpenVPN lifecycle: provisioning, removal, IP allocation, and SSH integration

src/main/java/com/litoralregas/openvpn/router/RouterController.java

@@ -45,13 +45,6 @@ public class RouterController {
         return service.findById(id);
     }
 
-    @PatchMapping("/{id}/status")
-    public Router updateStatus(
-            @PathVariable UUID id,
-            @Valid @RequestBody UpdateRouterStatusRequest request
-    ) {
-        return service.updateStatus(id, request);
-    }
 
     @DeleteMapping("/{id}")
     public void delete(@PathVariable UUID id) {
@@ -122,21 +115,32 @@ public class RouterController {
         var deployment = deploymentService.startDeployment(router, DeploymentAction.REMOVE);
 
         try {
-            service.forceStatus(id, RouterStatus.PROVISIONING); // or REMOVING if you want later
+            service.forceStatus(id, RouterStatus.REMOVING);
 
-            var result = sshService.executeOnConfiguredVps(
-                    "echo 'Removing router: " + router.getName() + "' && whoami && hostname"
+            var allocation = ipAllocationService.findByRouterId(id);
+
+            var result = openVpnService.removeClient(
+                    allocation.getClientName(),
+                    allocation.getLanSubnet()
             );
 
             if (result.exitCode() != 0) {
-                throw new IllegalStateException(result.stderr());
+                throw new IllegalStateException(
+                        "Remove failed. stdout: " + result.stdout()
+                                + " stderr: " + result.stderr()
+                );
             }
 
             var finished = deploymentService.finishSuccess(
                     deployment,
                     result.stdout()
             );
-            service.forceStatus(id, RouterStatus.REMOVED);
+
+            if (openVpnService.isDryRun()) {
+                service.forceStatus(id, RouterStatus.PROVISIONED);
+            } else {
+                service.forceStatus(id, RouterStatus.REMOVED);
+            }
 
             return DeploymentResponse.from(finished);
         } catch (Exception e) {